[FreeMarker-user] macro errors

[Sam Steingold]

Hi,
I am getting various macro errors:

<#macro sentiment scmr model><#if scmr??>
<#assign senti = "${scmr.results[model]}">
<#if senti??>
<td>${senti} ---- ${senti.sentimentType}</td>
<td>${senti.score?html}</td>
<#else><td align="center" colspan="2">none</td>
</#if>
</#if></#macro>

first error:

POSITIVE(1.0/1) ---- Expected hash. senti evaluated instead to freemarker.template.SimpleScalar

this is coming from "${senti} ---- ${senti.sentimentType}"
apparently, "senti" is the string representation of the object,
not the object itself.
how do I fix that?

second error:

Error executing macro: sentiment required parameter: scmr is not specified.

this is coming from this invocation:

<@sentiment model=model scmr=result.title/>

here `result' is non-null, but result.title is null.
I do check for that in the macro, but, apparently, it has to be done
outside. Why?

Thanks!

[Daniel Dekany]

Post by Sam Steingold
Hi,
<#macro sentiment scmr model><#if scmr??>
<#assign senti = "${scmr.results[model]}">
<#if senti??>
<td>${senti} ---- ${senti.sentimentType}</td>
<td>${senti.score?html}</td>
<#else><td align="center" colspan="2">none</td>
</#if>
</#if></#macro>
POSITIVE(1.0/1) ---- Expected hash. senti evaluated instead to freemarker.template.SimpleScalar
this is coming from "${senti} ---- ${senti.sentimentType}"
apparently, "senti" is the string representation of the object,
not the object itself.
how do I fix that?
Error executing macro: sentiment required parameter: scmr is not specified.
here `result' is non-null, but result.title is null.
I do check for that in the macro, but, apparently, it has to be done
outside. Why?

Yeah, the null-madness from the dark ages of FreeMarker, here to stay
with us as far as backward compatibility is kept. Basically, it's
suspected by FreeMarker that the expression result.title is a typo,
and that's why it's undefined (null), hence the error. Now, maybe it's
defined, like `result` is a JavaBean where you have a getTitle()
method that returns null, but FreeMarker doesn't differentiate,
because, if `result` is a Map on the Java-side and there's no title
then there's indeed no "title" key (hence it can't be told if
result.title is a typo or just Java-null). Surely you could tell that
if `result` is a JavaBean, but you should be to able to switch
back-and-forth between a JavaBean `result` and a Map `result` in the
data-model without changing (breaking) the behavior of templates, so
you get the common subset.

What to do? Here's a hack... If know that result.title should be a
String or null, you can call the macro as (note the "!"):

<@sentiment model=model scmr=result.title! />

Then in the macro you can do <#if a?is_sequence>title was null</#if>
or such.

There's also an old implementation bug (that's kept for
backward-compatibility), where, if you pass an undefined expression to
a macro as a parameter (like even something that's indeed a typo), and
the macro defines a default value for the parameter, that default
value will kick in. So if you prefer, you can just do this:

<#macro sentiment scmr! model><#if scmr?is_sequence>

and then you don't need the `!` when calling the macro.

BTW, instead of `?is_sequence` you could use `== ''` too, however if
the parameter can be legally an empty string then it's not a generic
solution.

Post by Sam Steingold
Thanks!

[Denis Bredelet]

Hi Sam

Post by Sam Steingold
Hi,
<#macro sentiment scmr model><#if scmr??>
<#assign senti = "${scmr.results[model]}">
<#if senti??>
<td>${senti} ---- ${senti.sentimentType}</td>
<td>${senti.score?html}</td>
<#else><td align="center" colspan="2">none</td>
</#if>
</#if></#macro>
POSITIVE(1.0/1) ---- Expected hash. senti evaluated instead to freemarker.template.SimpleScalar
this is coming from "${senti} ---- ${senti.sentimentType}"
apparently, "senti" is the string representation of the object,
not the object itself.
how do I fix that?

<#assign senti = scmr.results[model]>

-- Denis.

Post by Sam Steingold
Error executing macro: sentiment required parameter: scmr is not specified.
here `result' is non-null, but result.title is null.
I do check for that in the macro, but, apparently, it has to be done
outside. Why?

Yeah, the null-madness from the dark ages of FreeMarker, here to stay
with us as far as backward compatibility is kept. Basically, it's
suspected by FreeMarker that the expression result.title is a typo,
and that's why it's undefined (null), hence the error. Now, maybe it's
defined, like `result` is a JavaBean where you have a getTitle()
method that returns null, but FreeMarker doesn't differentiate,
because, if `result` is a Map on the Java-side and there's no title
then there's indeed no "title" key (hence it can't be told if
result.title is a typo or just Java-null). Surely you could tell that
if `result` is a JavaBean, but you should be to able to switch
back-and-forth between a JavaBean `result` and a Map `result` in the
data-model without changing (breaking) the behavior of templates, so
you get the common subset.
What to do? Here's a hack... If know that result.title should be a
Then in the macro you can do <#if a?is_sequence>title was null</#if>
or such.
There's also an old implementation bug (that's kept for
backward-compatibility), where, if you pass an undefined expression to
a macro as a parameter (like even something that's indeed a typo), and
the macro defines a default value for the parameter, that default
<#macro sentiment scmr! model><#if scmr?is_sequence>
and then you don't need the `!` when calling the macro.
BTW, instead of `?is_sequence` you could use `== ''` too, however if
the parameter can be legally an empty string then it's not a generic
solution.

Post by Sam Steingold
Thanks!

--
Best regards,
Daniel Dekany
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
FreeMarker-user mailing list
https://lists.sourceforge.net/lists/listinfo/freemarker-user

[Sam Steingold]

The following message is a courtesy copy of an article
that has been posted to gmane.comp.web.freemarker.user as well.

Thanks for your kind reply!

Post by Daniel Dekany

Post by Sam Steingold
<#macro sentiment scmr model><#if scmr??>
<#assign senti = "${scmr.results[model]}">
<#if senti??>
<td>${senti} ---- ${senti.sentimentType}</td>
<td>${senti.score?html}</td>
<#else><td align="center" colspan="2">none</td>
</#if>
</#if></#macro>
POSITIVE(1.0/1) ---- Expected hash. senti evaluated instead to freemarker.template.SimpleScalar
this is coming from "${senti} ---- ${senti.sentimentType}"
apparently, "senti" is the string representation of the object,
not the object itself.
how do I fix that?
Error executing macro: sentiment required parameter: scmr is not specified.
here `result' is non-null, but result.title is null.
I do check for that in the macro, but, apparently, it has to be done
outside. Why?

Yeah, the null-madness from the dark ages of FreeMarker, here to stay
with us as far as backward compatibility is kept. Basically, it's
suspected by FreeMarker that the expression result.title is a typo,
and that's why it's undefined (null), hence the error. Now, maybe it's
defined, like `result` is a JavaBean where you have a getTitle()
method that returns null, but FreeMarker doesn't differentiate,
because, if `result` is a Map on the Java-side and there's no title
then there's indeed no "title" key (hence it can't be told if
result.title is a typo or just Java-null). Surely you could tell that
if `result` is a JavaBean, but you should be to able to switch
back-and-forth between a JavaBean `result` and a Map `result` in the
data-model without changing (breaking) the behavior of templates, so
you get the common subset.

yes. result is a JavaBean in my case, and getTitle() is defined.

are you suggesting that "." denotes both hash table and field access?
i.e., I could have written scmr.results.model instead of
scmr.results[model], right?

Post by Daniel Dekany
There's also an old implementation bug (that's kept for
backward-compatibility), where, if you pass an undefined expression to
a macro as a parameter (like even something that's indeed a typo), and
the macro defines a default value for the parameter, that default
<#macro sentiment scmr! model><#if scmr?is_sequence>
and then you don't need the `!` when calling the macro.

I got
Encountered "!" at line 2, column 23 in com/addthis/sentiment/sentidemo.ftl.
Was expecting one of:
"=" ...
"..." ...
"," ...
")" ...
<ID> ...
">" ...

column 23 is "!" in scmr!


okay, here is what seems to be working for me:

<#macro sentiment scmr model><#if scmr != ''>
<#assign senti = scmr.results[model]>
<#if senti??>
<td>${senti.sentimentType}</td>
<td>${senti.score?html}</td>
<#else><td align="center" colspan="2">none</td>
</#if>
</#if></#macro>


<@sentiment model=model scmr=result.title! />
<@sentiment model=model scmr=result.body! />
<@sentiment model=model scmr=result.mean! />

the big question:
will the "<#if senti??>" test in the macro work as intended?
what is the value of "senti" anyway? a string? the java bean object?

thanks!

[Daniel Dekany]

Wednesday, July 25, 2012, 5:42:51 PM, Sam Steingold wrote:

[snip]

Post by Sam Steingold
yes. result is a JavaBean in my case, and getTitle() is defined.
are you suggesting that "." denotes both hash table and field access?

If the left-hand-operand is a java.util.Map, then it calls
Map.get(rho), otherwise it reads a JavaBean property or reads a public
Java field. Usually. To be exact, what "." does entirely depends on
the object_wrapper setting, and the type of the object. Like, if you
are using the default object wrapper, for a W3C DOM node it will issue
an XPath query.

Post by Sam Steingold
i.e., I could have written scmr.results.model instead of
scmr.results[model], right?

scmr.results["model"] is the same as scmr.results.model. But
scmr.results[model] is something different (dynamic key).

Post by Sam Steingold

Post by Daniel Dekany
There's also an old implementation bug (that's kept for
backward-compatibility), where, if you pass an undefined expression to
a macro as a parameter (like even something that's indeed a typo), and
the macro defines a default value for the parameter, that default
<#macro sentiment scmr! model><#if scmr?is_sequence>
and then you don't need the `!` when calling the macro.

I got
Encountered "!" at line 2, column 23 in
com/addthis/sentiment/sentidemo.ftl.

Eh... sorry. I meant:

<#macro sentiment scmr=false model><#if scmr?is_boolean>

Post by Sam Steingold
"=" ...
"..." ...
"," ...
")" ...
<ID> ...
">" ...
column 23 is "!" in scmr!
<#macro sentiment scmr model><#if scmr != ''>
<#assign senti = scmr.results[model]>
<#if senti??>
<td>${senti.sentimentType}</td>
<td>${senti.score?html}</td>
<#else><td align="center" colspan="2">none</td>
</#if>
</#if></#macro>
will the "<#if senti??>" test in the macro work as intended?

That line alone would, but <#assign senti = scmr.results[model]> will
fail if it evaluates to a null. In general, wherever you can get a
null during normal operation, you have to specify a default with "!".

Post by Sam Steingold
what is the value of "senti" anyway? a string? the java bean object?

I can't know, since I don't know your data-model. Looking at the macro
I guess it's a JavaBean.

Post by Sam Steingold
thanks!

[Sam Steingold]

The following message is a courtesy copy of an article
that has been posted to gmane.comp.web.freemarker.user as well.

Post by Daniel Dekany

Post by Sam Steingold
<#macro sentiment scmr model><#if scmr != ''>
<#assign senti = scmr.results[model]>
<#if senti??>
<td>${senti.sentimentType}</td>
<td>${senti.score?html}</td>
<#else><td align="center" colspan="2">none</td>
</#if>
</#if></#macro>
will the "<#if senti??>" test in the macro work as intended?

That line alone would, but <#assign senti = scmr.results[model]> will
fail if it evaluates to a null. In general, wherever you can get a
null during normal operation, you have to specify a default with "!".

you mean it should be

<#assign senti = scmr.results[model]! />

right?

Post by Daniel Dekany

Post by Sam Steingold
what is the value of "senti" anyway? a string? the java bean object?

I can't know, since I don't know your data-model. Looking at the macro
I guess it's a JavaBean.

what I meant was whether it was a java object or an html/freemarker string.


thanks!

[Daniel Dekany]

Post by Sam Steingold

Post by Daniel Dekany

Post by Sam Steingold
<#macro sentiment scmr model><#if scmr != ''>
<#assign senti = scmr.results[model]>
<#if senti??>
<td>${senti.sentimentType}</td>
<td>${senti.score?html}</td>
<#else><td align="center" colspan="2">none</td>
</#if>
</#if></#macro>
will the "<#if senti??>" test in the macro work as intended?

That line alone would, but <#assign senti = scmr.results[model]> will
fail if it evaluates to a null. In general, wherever you can get a
null during normal operation, you have to specify a default with "!".

you mean it should be
<#assign senti = scmr.results[model]! />
right?

Only if the default value that you want is empty string + empty
sequence + empty hash (a multi-type value). See:
http://freemarker.org/docs/dgui_template_exp.html#dgui_template_exp_missing

Also note that if you have a default value, then <#if senti??> will
never be executed, of course.

Post by Sam Steingold

Post by Daniel Dekany

Post by Sam Steingold
what is the value of "senti" anyway? a string? the java bean object?

I can't know, since I don't know your data-model. Looking at the macro
I guess it's a JavaBean.

what I meant was whether it was a java object or an html/freemarker string.

Assuming it's a JavaBean in Java, it's a hash (+ string) in the
type-system of FreeMarker. Assuming you are using the default object
wrapper at least.

Post by Sam Steingold
thanks!

[Sam Steingold]

Post by Daniel Dekany

Post by Sam Steingold
<#macro sentiment scmr model><#if scmr != ''>
<#assign senti = scmr.results[model]>
<#if senti??>
<td>${senti.sentimentType}</td>
<td>${senti.score?html}</td>
<#else><td align="center" colspan="2">none</td>
</#if>
</#if></#macro>
will the "<#if senti??>" test in the macro work as intended?

That line alone would, but <#assign senti = scmr.results[model]> will
fail if it evaluates to a null. In general, wherever you can get a
null during normal operation, you have to specify a default with "!".

you mean it should be

<#assign senti = scmr.results[model]! />

right?

Post by Daniel Dekany

Post by Sam Steingold
what is the value of "senti" anyway? a string? the java bean object?

I can't know, since I don't know your data-model. Looking at the macro
I guess it's a JavaBean.

what I meant was whether it was a java object or an html/freemarker string.


thanks!

[Sam Steingold]

Thanks for your kind reply!

Post by Daniel Dekany

Post by Sam Steingold
<#macro sentiment scmr model><#if scmr??>
<#assign senti = "${scmr.results[model]}">
<#if senti??>
<td>${senti} ---- ${senti.sentimentType}</td>
<td>${senti.score?html}</td>
<#else><td align="center" colspan="2">none</td>
</#if>
</#if></#macro>
POSITIVE(1.0/1) ---- Expected hash. senti evaluated instead to freemarker.template.SimpleScalar
this is coming from "${senti} ---- ${senti.sentimentType}"
apparently, "senti" is the string representation of the object,
not the object itself.
how do I fix that?
Error executing macro: sentiment required parameter: scmr is not specified.
here `result' is non-null, but result.title is null.
I do check for that in the macro, but, apparently, it has to be done
outside. Why?

Yeah, the null-madness from the dark ages of FreeMarker, here to stay
with us as far as backward compatibility is kept. Basically, it's
suspected by FreeMarker that the expression result.title is a typo,
and that's why it's undefined (null), hence the error. Now, maybe it's
defined, like `result` is a JavaBean where you have a getTitle()
method that returns null, but FreeMarker doesn't differentiate,
because, if `result` is a Map on the Java-side and there's no title
then there's indeed no "title" key (hence it can't be told if
result.title is a typo or just Java-null). Surely you could tell that
if `result` is a JavaBean, but you should be to able to switch
back-and-forth between a JavaBean `result` and a Map `result` in the
data-model without changing (breaking) the behavior of templates, so
you get the common subset.

yes. result is a JavaBean in my case, and getTitle() is defined.

are you suggesting that "." denotes both hash table and field access?
i.e., I could have written scmr.results.model instead of
scmr.results[model], right?

Post by Daniel Dekany
There's also an old implementation bug (that's kept for
backward-compatibility), where, if you pass an undefined expression to
a macro as a parameter (like even something that's indeed a typo), and
the macro defines a default value for the parameter, that default
<#macro sentiment scmr! model><#if scmr?is_sequence>
and then you don't need the `!` when calling the macro.

I got
Encountered "!" at line 2, column 23 in com/addthis/sentiment/sentidemo.ftl.
Was expecting one of:
"=" ...
"..." ...
"," ...
")" ...
<ID> ...
">" ...

column 23 is "!" in scmr!


okay, here is what seems to be working for me:

<#macro sentiment scmr model><#if scmr != ''>
<#assign senti = scmr.results[model]>
<#if senti??>
<td>${senti.sentimentType}</td>
<td>${senti.score?html}</td>
<#else><td align="center" colspan="2">none</td>
</#if>
</#if></#macro>


<@sentiment model=model scmr=result.title! />
<@sentiment model=model scmr=result.body! />
<@sentiment model=model scmr=result.mean! />

the big question:
will the "<#if senti??>" test in the macro work as intended?
what is the value of "senti" anyway? a string? the java bean object?

thanks!